Azure gov client changes #1249
Merged
Azure gov client changes #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onkarbhat
approved these changes
Feb 16, 2022
pkg/blockstorage/azure/client.go
Outdated
| @@ -118,12 +116,12 @@ func getAuthorizer(env azure.Environment, config map[string]string) (*autorest.B | |||
| } | |||
|
|
|||
| credConfig := auth.NewClientCredentialsConfig(clientID, clientSecret, tenantID) | |||
| if aDDEndpoint, ok := config[blockstorage.AzureActiveDirEndpoint]; ok { | |||
| credConfig.AADEndpoint = aDDEndpoint | |||
| if credConfig.AADEndpoint, ok = config[blockstorage.AzureActiveDirEndpoint]; !ok { | |||
There was a problem hiding this comment.
Can we add unit tests to verify this logic where we default to env.Something if ok is false, and verify that we use the config passed in config[some field] when ok is true ?
There was a problem hiding this comment.
Yea I'm trying to find a way to unit test this
leuyentran
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following PR takes the environment name config value and uses it to set the other environment variables. It also allows the other provided config values to override these.
We also need to uses the
WithBaseURIversions of calls to create clients. This will ensure the client points to the right endpoint.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan