Adding context to log statements #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaitanya-baraskar
force-pushed
the
jobID
branch
3 times, most recently
from
6e33a6f
to
c9704fa
Compare
chaitanya-baraskar
force-pushed
the
jobID
branch
3 times, most recently
from
6a76b1f
to
0ffb636
Compare
chaitanya-baraskar
force-pushed
the
jobID
branch
from
0ffb636
to
60c52f8
Compare
ihcsim
reviewed
Mar 2, 2022
pavannd1
reviewed
Mar 3, 2022
pavannd1
reviewed
Mar 23, 2022
julio-lopez
reviewed
Mar 24, 2022
julio-lopez
reviewed
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Adding context to log statements. ActionSet name is being passed as context field. Updated log statements to use context so all relevant logs from ActionSet can be traced together.
Added feature where kanister picks labels with prefix
kanister.io/for logging.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
For testing, I tried MsSQL blueprint - https://github.com/kanisterio/kanister/tree/master/examples/stable/mssql
Deployed application using steps given in README.md and tried backup restore command. Attaching gist of generated output.
Output before changes - https://gist.github.com/chaitanya-baraskar/4db6c3495905e43065163049c37f52d6
Output after changes in this PR - https://gist.github.com/chaitanya-baraskar/822a9148f0b4085fbf6da81a6f7cb4a6