Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor issues in postgres readme.md #1264

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Fix minor issues in postgres readme.md #1264

merged 2 commits into from
Mar 2, 2022

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

  • replcae kasten-io namespace with kanister
  • POSTGRES_USER env var is not set anymore, use postgres
  • Use correct create table command

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

NA

@viveksinghggits
Fix minor issues in postgres readme.md
aec35f1 
- replcae `kasten-io` namespace with `kanister`
- `POSTGRES_USER` env var is not set anymore, use `postgres`
- Use correct `create table` command
akankshakumari393
akankshakumari393 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ihcsim
ihcsim approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍!

@mergify mergify bot merged commit 6f2ef01 into master Mar 2, 2022
@mergify mergify bot deleted the postgres-bp-fix branch March 2, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcsim ihcsim ihcsim approved these changes

@akankshakumari393 akankshakumari393 akankshakumari393 approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viveksinghggits @ihcsim @akankshakumari393