-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm test to check kanister upgrades #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksinghggits
force-pushed
the
helm-test
branch
from
March 2, 2022 17:00
3490354
to
6d549e8
Compare
viveksinghggits
requested review from
PrasadG193,
ankitjain235,
ihcsim and
pavannd1
and removed request for
ankitjain235
March 2, 2022 17:06
ihcsim
reviewed
Mar 15, 2022
viveksinghggits
force-pushed
the
helm-test
branch
from
March 16, 2022 10:14
0eafe16
to
45a8f48
Compare
This PR adds helm test that installs kanister from released version then upgrades that to chart to make sure we have not introduced any breaking chnages and people will be able to upgrade without any issues. We also use latest controller image when we upgrade with local chart.
Instead of creating the namespace manually before installing a release, we can use `--create-namespace` flag in `helm install` command that creates the namespace if not present.
viveksinghggits
force-pushed
the
helm-test
branch
from
March 17, 2022 09:44
e2039cf
to
3f97ae9
Compare
ihcsim
reviewed
Mar 17, 2022
pavannd1
reviewed
Mar 18, 2022
ihcsim
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds helm test that installs kanister from
released version then upgrades that to chart to
make sure we have not introduced any breaking chnages
and people will be able to upgrade without any issues.
We also use latest controller image when we upgrade
with local chart.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Logs can be found here.
Logs are here.