Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm test to check kanister upgrades #1265

Merged
merged 9 commits into from
Mar 22, 2022
Merged

Add helm test to check kanister upgrades #1265

merged 9 commits into from
Mar 22, 2022

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

This PR adds helm test that installs kanister from
released version then upgrades that to chart to
make sure we have not introduced any breaking chnages
and people will be able to upgrade without any issues.
We also use latest controller image when we upgrade
with local chart.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
make integration-test

Logs can be found here.

make helm-test

Logs are here.

pkg/helm/client.go Outdated Show resolved Hide resolved
pkg/helm/client.go Outdated Show resolved Hide resolved
pkg/testing/helm/helm_test.go Show resolved Hide resolved
This PR adds helm test that installs kanister from
released version then upgrades that to chart to
make sure we have not introduced any breaking chnages
and people will be able to upgrade without any issues.
We also use latest controller image when we upgrade
with local chart.
Instead of creating the namespace manually before installing
 a release, we can use `--create-namespace` flag in `helm
install` command that creates the namespace if not present.
pkg/helm/client.go Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
build/helm-test.sh Outdated Show resolved Hide resolved
pkg/testing/helm/helm_app.go Outdated Show resolved Hide resolved
pkg/testing/helm/helm_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@mergify mergify bot merged commit 9715d7b into master Mar 22, 2022
@mergify mergify bot deleted the helm-test branch March 22, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants