Add ability to set azure environment for stow #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bathina2
requested review from
AlekseyBlokhin,
DeepikaDixit,
leuyentran,
miquella and
onkarbhat
and removed request for
AlekseyBlokhin
leuyentran
reviewed
Mar 8, 2022
| @@ -45,6 +45,8 @@ type SecretAzure struct { | |||
| StorageAccount string | |||
| // storage key | |||
| StorageKey string | |||
| // environment name | |||
There was a problem hiding this comment.
@bathina2 does Env need to be a Secret?
Merge branch 'master' of https://github.com/kanisterio/kanister into az-gov-stow-changes
Merge branch 'az-gov-stow-changes' of https://github.com/kanisterio/kanister into az-gov-stow-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following PR updates the secret definition for azure. It add the environment name field.
The azure config command then uses this variable to prepare the config for stow.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan