-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove helm2 references #1270
remove helm2 references #1270
Conversation
docs/helm.rst
Outdated
@@ -26,7 +26,7 @@ You also need to install the Kanister controller | |||
|
|||
.. substitution-code-block:: console | |||
|
|||
$ helm install --name myrelease --namespace kanister kanister/kanister-operator --set image.tag=|version| | |||
$ helm install myrelease --namespace kanister kanister/kanister-operator --set image.tag=|version| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helm install
supports a --create-namespace
option to create the release namespace, if it's missing. Unless there is an explicit separate command to create the namespace, we should add this option to all helm install
examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kale-amruta thanks for the updates. Can you add the --create-namespace
option to the other example code too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ihcsim I have updated all the examples but have left applications under these docs since these are stale and we are not really maintaining these helm charts in the kanister docs eg: https://docs.kanister.io/helm_instructions/mysql_instructions.html
We should probably remove these docs as we are using examples to install the applications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind creating a documentation
issue to track the task to remove those examples? Thanks.
63462fa
to
94fdc9c
Compare
@kale-amruta please resolve conflicts and update the PR whenever possible 👍🏼 |
e870bcc
to
5a786d8
Compare
Change Overview
Remove helm2 references from the docs
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan