Changes to support Secret Credential type for azure #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavannd1
reviewed
Mar 10, 2022
Merge branch 'master' of https://github.com/kanisterio/kanister into profile-secret-change
Merge branch 'master' of https://github.com/kanisterio/kanister into profile-secret-change
ihcsim
reviewed
Mar 15, 2022
Merge branch 'master' of https://github.com/kanisterio/kanister into profile-secret-change
Merge branch 'master' of https://github.com/kanisterio/kanister into profile-secret-change
bathina2
changed the title
onkarbhat
approved these changes
Mar 23, 2022
| @@ -234,26 +233,59 @@ func getLocationParams(cmd *cobra.Command) (*locationParams, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| func constructProfile(lP *locationParams, secret *v1.Secret, role string) *v1alpha1.Profile { | |||
| func constructProfile(lP *locationParams, secret *v1.Secret) *v1alpha1.Profile { | |||
There was a problem hiding this comment.
I noticed that there are no unit tests for testing either constructProfile/constructSecret or even the caller createNewProfile(used in newAzureProfileCmd/newGCPProfileCmd/newS3CompliantProfileCmd). It would be useful to add tests using fake kube clients.
| retCredType: v1alpha1.CredentialTypeKeyPair, | ||
| }, | ||
| } { | ||
| prof := constructProfile(tc.lp, tc.secret) |
There was a problem hiding this comment.
Ah nice. I read the test file after adding my comment about testing in profile.go. Happy to see that you have already added the test 👍🏼 .
pkg/secrets/azure.go
Outdated
| azSecret.EnvironmentName = string(envName) | ||
| } | ||
| if azSecret.StorageAccount == "" || azSecret.StorageKey == "" { | ||
| return nil, errors.New("Azure secret is missing storage account name or storage key") |
There was a problem hiding this comment.
Suggested change
| return nil, errors.New("Azure secret is missing storage account name or storage key") | |
| return nil, errors.New("Azure secret is missing storage account ID or storage key") |
pkg/validate/validate.go
Outdated
| // The following is KeyPair codepath | ||
| kp := p.Credential.KeyPair | ||
| if kp == nil { | ||
| return nil, errorf(validateErr, "Invalid credentials kv cannot be nil") |
There was a problem hiding this comment.
Suggested change
| return nil, errorf(validateErr, "Invalid credentials kv cannot be nil") | |
| return nil, errorf(validateErr, "Invalid credentials kp cannot be nil") |
|
@bathina2 Removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The following PR enables Secret Credetial type for azure. This allows us to pass the azure cloud environment down as an argument in the secret.
This PR also uses an updated stow version.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan