Fix KubeExec args in cassandra blueprint
#1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the cassandra-blueprint for `KubeExec` function in 2 phases we were using `containers` arguments which is not supported by the function. This has been working I think, because the container defaults to the main container in the pod. The is the reason instead of correct the typo am removing it so that the behaviour, how it has been runnig till now would not be changed.
pavannd1
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
In the cassandra-blueprint for
KubeExecfunctionin 2 phases we were using
containersarguments whichis not supported by the function.
This has been working I think, because the container
defaults to the main container in the pod.
The is the reason instead of correct the typo
am removing it so that the behaviour, how it has
been runnig till now would not be changed.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Run blueprint validator to check if the blueprint is valid.