Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Arguments method for rds functions #1281

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Fix Arguments method for rds functions #1281

merged 2 commits into from
Mar 14, 2022

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

Arguments method for RDS functions didnt have all the supported arguments. This fixes that.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

NA

ankitjain235
ankitjain235 reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

pkg/function/restore_rds_snapshot.go Show resolved Hide resolved
akankshakumari393
akankshakumari393 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 9834207 into master Mar 14, 2022
@mergify mergify bot deleted the restore-rds-fix branch March 14, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitjain235 ankitjain235 ankitjain235 left review comments

@chaitanya-baraskar chaitanya-baraskar chaitanya-baraskar approved these changes

@akankshakumari393 akankshakumari393 akankshakumari393 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@viveksinghggits @chaitanya-baraskar @ankitjain235 @akankshakumari393