Add CONTRIBUTING.md, GOVERNANCE.md, MAINTAINERS.md Docs #1287
Conversation
This will be re-added once we have decided on the support policy Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
|
LGTM |
| made. | ||
| ``` | ||
|
|
||
| ### Submitting Pull Requests |
There was a problem hiding this comment.
Hi @ihcsim
is it a good idea to ask people to confirm with maintainers if the pull request that they are trying to raise would be a good addition. In some cases there are chances that the PR is raised but the maintainers don't think that the PR should get in.
There was a problem hiding this comment.
Absolutely. Ideally, we would have prior discussion in GitHub issues/discussions, before pull requests are submitted. That's why in this section, I directed contributors to look up GitHub issues first.
There was a problem hiding this comment.
I think it is okay to determine this on the PR itself. At least that's what I have seen on some other OSS repos
|
|
||
| ### Creating A Local Build | ||
|
|
||
| See the [BUILD.md](BUILD.md) document for instructions on how to build, test and |
There was a problem hiding this comment.
are we yet to push the build.md?
There was a problem hiding this comment.
It will be in a separate PR.
Change Overview
This PR adds the 1st iteration of the following docs to the repository:
Instructions on how to create and test a local build will be added to BUILD.md in a separate PR.
Pull request type
Please check the type of change your PR introduces:
Issues
Fix #1119
Fix #1234