Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section "Webhook" in "Troubleshooting" #1309

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

muffl0n
Copy link
Contributor

@muffl0n muffl0n commented Mar 22, 2022

Change Overview

I stumbled upon not being able to apply a blueprint in #1292. This PR adds a section "Webhook" to "Troubleshooting" to describe was has to be done, in order to getting this to work on a GKE cluster.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
@viveksinghggits
Copy link
Contributor

@muffl0n can you please build the docs and share the screen shot of how things are looking.

@muffl0n muffl0n force-pushed the add-troubleshoot-webhook branch 3 times, most recently from db3ac43 to 5e6be43 Compare March 22, 2022 09:53
@muffl0n
Copy link
Contributor Author

muffl0n commented Mar 22, 2022

Sure!
Bildschirmfoto 2022-03-22 um 10 53 22

Thanks for your input!

Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
docs/troubleshooting.rst Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
@muffl0n
Copy link
Contributor Author

muffl0n commented Mar 23, 2022

Thanks for your suggestions!
Bildschirmfoto 2022-03-23 um 09 24 00

@shuguet shuguet added this to Review in progress in Kanister Mar 23, 2022
Kanister automation moved this from Review in progress to Reviewer approved Mar 23, 2022
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ihcsim ihcsim added the kueue label Mar 23, 2022
docs/troubleshooting.rst Show resolved Hide resolved
docs/troubleshooting.rst Outdated Show resolved Hide resolved
@mergify mergify bot merged commit e49103b into kanisterio:master Mar 24, 2022
Kanister automation moved this from Reviewer approved to Done Mar 24, 2022
@muffl0n muffl0n deleted the add-troubleshoot-webhook branch March 29, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants