Phase output params; Objectstore helpers; #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support return values from Kanister functions * Change all Kanister functions to return output * Change function signature in all the tests * Move RenderArgs logic into Exec * Add output function unit test * Fix phase unit test * Minor improvement to func unit test
Add get/put/delete data helper functions to objectstore #K10-1536
* Kando command for creating phase output * Fix typo * Minor improvements
Move command generation into the `restic` pkg. Allows for re-use in other functions
* Add helpers to run a pod * Address review comments
* Move restic repo init into restic pkg * Address review comments
* Add a CopyVolumeData function This Kanister function can be used to copy data from a PVC to an objectstore location. It leverages the restic pkg and the artifacts should be compatible with the `RestoreData` function * Address review comments
* WIP Render ArtifactsOut after all the phases * Render arts inside go routine * Remove ArtifactsOut from TemplateParams * Add Unit test to check artifacts update * Fix ActionSet update
…4110) This reverts commit 7ccf63251ac301eac88cd896883292732fdf7dcd.
* KubeExec: parse logs and return output * Incorporated review comments
* WIP Render ArtifactsOut after all the phases * Render arts inside go routine * Remove ArtifactsOut from TemplateParams * Add Unit test to check artifacts update * Fix ActionSet update * Restructure actionset update * Minor log update
* Fix actionset based kube tests * Minor readability fix
SupriyaKasten
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.