Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose efs type and some utility functions #1311

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Expose efs type and some utility functions #1311

merged 3 commits into from
Mar 23, 2022

Conversation

leuyentran
Copy link
Contributor

@leuyentran leuyentran commented Mar 22, 2022 •
edited

Change Overview

Expose AWS utility function and provider type for derivative works.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@shuguet shuguet added this to Review in progress in Kanister Mar 23, 2022
@leuyentran leuyentran self-assigned this Mar 23, 2022
@leuyentran leuyentran mentioned this pull request Mar 23, 2022
Closed
10 tasks
onkarbhat
onkarbhat approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@onkarbhat onkarbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from Review in progress to Reviewer approved Mar 23, 2022
@mergify mergify bot merged commit 428c402 into master Mar 23, 2022
Kanister automation moved this from Reviewer approved to Done Mar 23, 2022
@mergify mergify bot deleted the expose-efs-from-kanister-new branch March 23, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarbhat onkarbhat onkarbhat approved these changes

@pavannd1 pavannd1 pavannd1 approved these changes

@bathina2 bathina2 Awaiting requested review from bathina2

@carlbraganza carlbraganza Awaiting requested review from carlbraganza

Assignees

@leuyentran leuyentran

Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leuyentran @onkarbhat @pavannd1