Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm flag to enable/disable installation of valwebhook #1327

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

This PR adds a helm flag bpValidatingWebhook.enabled
that can be used to specify if we want to install validating
webhook that validates the blueprints or not.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

» helm install kanister -n kanister helm/kanister-operator --set bpValidatingWebhook.enabled=true  --dry-run  > kanister.yaml

The output file can be found here.

» helm install kanister -n kanister helm/kanister-operator --set bpValidatingWebhook.enabled=false  --dry-run  > kanister.yaml

the output file can be found here.

make helm-test

the output can be found here.

This commit adds a helm flag `bpValidatingWebhook.enabled`
that can be used to specify if we want to install validating
webhook that validates the blueprints or not.
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit fb8315e into master Mar 24, 2022
@mergify mergify bot deleted the kantest-valihook-fix branch March 24, 2022 18:14
@shuguet shuguet added this to In Progress in Kanister via automation Mar 25, 2022
@shuguet shuguet moved this from In Progress to Done in Kanister Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants