Kanister efs backups remove reference to k10 #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leuyentran
requested review from
bathina2,
onkarbhat,
pavannd1 and
carlbraganza
onkarbhat
reviewed
Mar 24, 2022
onkarbhat
reviewed
Mar 24, 2022
| @@ -92,7 +90,7 @@ func NewEFSProvider(ctx context.Context, config map[string]string) (blockstorage | |||
|
|
|||
| efsVault, ok := config[awsconfig.ConfigEFSVaultName] | |||
| if !ok || efsVault == "" { | |||
| efsVault = defaultK10BackupVaultName | |||
| return nil, errors.New("EFS vault name is empty") | |||
There was a problem hiding this comment.
Now that you have changed an assumption, I would expect that this would break some unit test in this package ? If not, then that means tests are missing . If so please add them.
There was a problem hiding this comment.
In k10, efs_kube_test will need to be updated. There is no unit test for NewEFSProvider in kanister however. Let me look into how best test it since the function actually validates creds with AWS
There was a problem hiding this comment.
unit test added with 59fb0e5c253bdccf3a688c46c76bcebd7dec7f0f
bathina2
reviewed
Mar 28, 2022
bathina2
approved these changes
Mar 29, 2022
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
CreateBackupVaultWrapperfor derivative work.SnapshotsListWLimitfunctionPull request type
Please check the type of change your PR introduces:
Test Plan