Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to redefine shorthand, prob in create profile azure #1334

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

Fixes #1333

We can try to come up with the shorthand flag but I think we its ok if we don't provide the shorthand here. The other thing is should we try to check the same problem with other flag combinations. I still see some other instances of same characters being used as shorthand flag.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

Build the binary and run the same command again

» ./kanctl create profile azure
Error: required flag(s) "storage-account", "storage-key" not set
Usage:
  kanctl create profile azure [flags]

Flags:
  -h, --help                     help for azure
  -a, --storage-account string   Storage account name of the azure storage
      --storage-env string       The Azure cloud environment
  -s, --storage-key string       Storage account key of the azure storage

Global Flags:
  -b, --bucket string           object store bucket name
      --dry-run                 if set, resource YAML will be printed but not created
  -e, --endpoint string         endpoint URL of the object store bucket
  -n, --namespace string        Override namespace obtained from kubectl context
  -p, --prefix string           prefix URL of the object store bucket
  -r, --region string           region of the object store bucket
      --skip-SSL-verification   if set, SSL verification is disabled for the profile
      --skip-validation         if set, resource is not validated before creation
      --verbose                 Display verbose output


Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍!

I still see some other instances of same characters being used as shorthand flag.

Can we create a bug issue to track those? Thanks.

@ihcsim ihcsim added the kueue label Mar 28, 2022
@mergify mergify bot merged commit ecbf4eb into master Mar 28, 2022
@mergify mergify bot deleted the azure-prof-create-fix branch March 28, 2022 18:21
@shuguet shuguet added this to In Progress in Kanister via automation Mar 28, 2022
@shuguet shuguet moved this from In Progress to Done in Kanister Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Creating azure profile fails with "unable to redefine 'e' shorthand in "azure" flagset"
3 participants