Add test for deferPhase in blueprint actions
#1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksinghggits
force-pushed
the
eventual-phase
branch
from
e71cc39
to
2618937
Compare
viveksinghggits
force-pushed
the
eventual-phase-test
branch
2 times, most recently
from
3bf40c9
to
5aaf6bc
Compare
|
travis is somehow not run in the last commit, its just mergify thats run. 😶🌫️ |
10 tasks
viveksinghggits
force-pushed
the
eventual-phase-test
branch
3 times, most recently
from
ef48a0e
to
b6e482d
Compare
|
@ihcsim this can also be reviewed. |
viveksinghggits
force-pushed
the
eventual-phase
branch
from
4a5d9c5
to
e8c4853
Compare
viveksinghggits
force-pushed
the
eventual-phase-test
branch
from
b6e482d
to
122f0e3
Compare
ihcsim
approved these changes
Apr 6, 2022
ihcsim
approved these changes
Apr 7, 2022
Blueprints can now define `deferPhase` for every action that would be run once all (some in case of failure) the phases of a blueprint action are run.
This commit adds a test that uses a blueprint with `deferPhase` and consumes artifacts in other action.
1. Make the phase function generic so that it can be used by restore phase as well deferPhase 2. unset the env var that is set in test
viveksinghggits
force-pushed
the
eventual-phase-test
branch
from
85f27d7
to
bc25a86
Compare
1. travis CI has been consistently failing recenlty with below error
```
FAIL: crd_test.go:30: CRDSuite.TestCRDMatcher
crd_test.go:49:
c.Assert(len(igvrs)+len(egvrs), Equals, len(gvrs))
... obtained int = 64
... expected int = 32
OOPS: 0 passed, 1 FAILED
```
And this happens if there are no CRDs present in the cluster. This
commit installs CSI hostpath that installs some CRDs.
2. We were running `helm-test` twice unknowlingly, this resolves that as
well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
As part of this PR we tried to add an eventual phase in the kanister blueprint action.
This PR adds test for that change.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
The logs can be found here.