-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional wait flag to scaleWorkload function #1350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kale-amruta
force-pushed
the
ScaleWorkloadWaitOptional
branch
from
April 4, 2022 10:41
d4b394f
to
f65514b
Compare
pavannd1
reviewed
Apr 5, 2022
pavannd1
reviewed
Apr 5, 2022
ihcsim
reviewed
Apr 7, 2022
ihcsim
reviewed
Apr 11, 2022
ihcsim
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍. Thanks for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Currently ScaleWorkload function waits for the workload to be ready for the function to be complete. This PR adds a flag to make the wait optional
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Used the flag in cassandra blueprint, and changed the function
bringupPod
in restore phase and tested these scenarioswaitForReady
, thebringupPod
function waited for the pods to be inready
state since thats the default behaviorwaitForReady: false
, thebringupPod
function did not wait for the pod to be inready
state and started executing the next functionwaitForReady: true
, thebringupPod
function waited for the pod to be inready
statewaitForReady: "xyz"
, thebringupPod
function failed to execute because it needed bool value to be passed