Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable grpc for connecting to Kopia API Server #1382

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Conversation

ankitjain235
Copy link
Contributor

Change Overview

This PR stops setting DisableGRPC to true, thus allowing Kopa API client to connect to server using GRPC.
Note: The kopia API server also needs to be started with GRPC enabled.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@mergify mergify bot merged commit 6bbc65f into master Apr 19, 2022
@mergify mergify bot deleted the kopia-api-client-grpc branch April 19, 2022 05:24
@shuguet shuguet added this to In Progress in Kanister via automation Apr 21, 2022
@shuguet shuguet moved this from In Progress to Done in Kanister Apr 21, 2022
ankitjain235 added a commit that referenced this pull request Apr 22, 2022
mergify bot pushed a commit that referenced this pull request Apr 22, 2022
ankitjain235 added a commit that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants