Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render artifacts if any of the phases are failed #1393

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Apr 20, 2022

Change Overview

We used to try to render artifacts for the succeeded phases
even if some of the phases are failed. That lead to a lot
confusion, even if the phases failed it looked like only
rendering has failed.
This is how things were being done earlier, but in the last PR where
we added support for eventual phase we tried to update that a bit.

This PR tries to fix that.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
» go test -check.f "ControllerSuite"
OK: 11 passed, 1 skipped
PASS
ok  	github.com/kanisterio/kanister/pkg/controller	110.194s

Full logs can be found here.

We used to try to render artifacts for the succeeded phases
even if some of the phases are failed. That lead to a lot
confusion, even if the phases failed it looked like only
rendering has failed.
This PR tries to fix that.
@pavannd1 pavannd1 added the kueue label Apr 20, 2022
@mergify mergify bot merged commit 37c8da6 into master Apr 20, 2022
@mergify mergify bot deleted the deferphase-bugfix branch April 20, 2022 19:12
@shuguet shuguet added this to In Progress in Kanister via automation Apr 21, 2022
@shuguet shuguet moved this from In Progress to Done in Kanister Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants