Don't render artifacts if any of the phases are failed #1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
We used to try to render artifacts for the succeeded phases
even if some of the phases are failed. That lead to a lot
confusion, even if the phases failed it looked like only
rendering has failed.
This is how things were being done earlier, but in the last PR where
we added support for eventual phase we tried to update that a bit.
This PR tries to fix that.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Full logs can be found here.