Compatible ResourceTypeMatcher with exact match for core #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off kueue-ing until downstream test fixes are ready, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR replaces #1390 to maintain compatibility for prior uses of empty group as matching
any group. This maintains consistency for empty values of G, V, or R. And it allows ResourceTypeRequirements with just a resource value to filter from GVR lists when it is unambiguous.
A new sentinel value of "core" is added that can be used to strictly match GVRs for K8s
core group resources.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan