Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deferPhaes function to not mention image #1399

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

Image that we mentioned in the deferPhase example got stale because of merge order. Its better to use kubeexec instead and not mention the image.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

make docs
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit fc0978f into master Apr 22, 2022
@mergify mergify bot deleted the docs-minor-fix branch April 22, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants