Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mergify to check GHA status #1426

Merged
merged 1 commit into from
May 4, 2022
Merged

Update mergify to check GHA status #1426

merged 1 commit into from
May 4, 2022

Conversation

pavannd1
Copy link
Contributor

@pavannd1 pavannd1 commented May 4, 2022

Change Overview

  • Remove Travis CI status check and replace it with GHA jobs

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister May 4, 2022
Kanister automation moved this from In Progress to Reviewer approved May 4, 2022
@infraq infraq added the kueue label May 4, 2022
@pavannd1 pavannd1 removed the kueue label May 4, 2022
Comment on lines +7 to +8
- check-success=test
- check-success=build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these match build (...) and test (...) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this, the job name should work - https://docs.mergify.com/conditions/#github-actions
Let's try it out 🤔

@pavannd1 pavannd1 merged commit 04fc133 into master May 4, 2022
@pavannd1 pavannd1 deleted the up-mergify-gha branch May 4, 2022 19:39
Kanister automation moved this from Reviewer approved to Done May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants