Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert k8s dependencies to 0.23.5 #1452

Merged
merged 2 commits into from
Jun 1, 2022
Merged

revert k8s dependencies to 0.23.5 #1452

merged 2 commits into from
Jun 1, 2022

Conversation

kale-amruta
Copy link
Contributor

Change Overview

revert k8s dependencies to 0.23.5 since 0.24.0 is breaking aws clusters

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #XXX

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
make[1]: Entering directory '/home/infracloud/go/src/github.com/kanisterio/kanister'
running CMD in the containerized build environment
+ export GO111MODULE=on
+ GO111MODULE=on
+ go mod download
++ go list -f '{{.Version}}' -m k8s.io/code-generator
+ execDir=/root/go/pkg/mod/k8s.io/code-generator@v0.23.5
+ chmod +x /root/go/pkg/mod/k8s.io/code-generator@v0.23.5/generate-groups.sh
+ /root/go/pkg/mod/k8s.io/code-generator@v0.23.5/generate-groups.sh all github.com/kanisterio/kanister/pkg/client github.com/kanisterio/kanister/pkg/apis cr:v1alpha1 --go-header-file /root/go/pkg/mod/k8s.io/code-generator@v0.23.5/hack/boilerplate.go.txt -o /go/src/
go: downloading k8s.io/klog/v2 v2.30.0
go: downloading golang.org/x/tools v0.1.6-0.20210820212750-d4cc65f0b2ff
go: downloading golang.org/x/sys v0.0.0-20210831042530-f4d43177bf5e
go: downloading golang.org/x/mod v0.4.2
go: downloading golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1
Generating deepcopy funcs
Generating clientset for cr:v1alpha1 at github.com/kanisterio/kanister/pkg/client/clientset
Generating listers for cr:v1alpha1 at github.com/kanisterio/kanister/pkg/client/listers
Generating informers for cr:v1alpha1 at github.com/kanisterio/kanister/pkg/client/informers
make[1]: Leaving directory '/home/infracloud/go/src/github.com/kanisterio/kanister'

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 added the kueue label Jun 1, 2022
@mergify mergify bot merged commit 0120298 into master Jun 1, 2022
@mergify mergify bot deleted the revert-client-go-update branch June 1, 2022 17:02
kale-amruta added a commit that referenced this pull request Jun 7, 2022
kale-amruta added a commit that referenced this pull request Jun 27, 2022
mergify bot pushed a commit that referenced this pull request Jun 27, 2022
* Revert "revert k8s dependencies to 0.23.5 (#1452)"

This reverts commit 0120298.

* update client go patch version to 0.24.1 and controller runtime to 0.12.1

* resolve conflicts

Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants