Fix kanister service port issue in case if webhook is disabled #1476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
In the cases where we install Kanister with webhook enabled we create a service (443) that forwards the request to port 9443 on container. When we upgrade kanister with
--set bpValidatingWebhook.enabled=false
the service should listen on 8000 and forward the request to port 8000 on container.This was not happening already, this PR tries to do that.
There was another request in the issue #1376, that says the metrics and healthz endpoint should also not be changed, if we toggle the value
bpValidatingWebhook.enabled
. Should we handle that as separate PR.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan