Add configmapName and secretName field to RDSPostgresDB app #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
akankshakumari393
requested review from
pavannd1,
PrasadG193 and
viveksinghggits
ihcsim
approved these changes
Jun 16, 2022
|
@akankshakumari393 is anything left with this PR? |
|
/ok-to-test |
akankshakumari393
force-pushed
the
rds_rename
branch
from
2c104d9
to
c92222b
Compare
|
I will merge this PR once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR add
configmapNameandsecretNamefield to RDSPostgresDB app. This would get us custom name to the secret and configmap installed as a part of the App Installation. Until now we were using constant values for naming these. This would have given a error if we were to install two apps in same namespace.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan