Removing dead code in tests

[faradayfan]

Change Overview

The PR removes some dead code in pkg/function/scale_test.go. The reasons for this proposed change are center around the idea that the use of SucceedNow() should be avoided. A few reasons for this are:

1. It creates dead code. This results in a more complicated codebase without any benefit.
2. It passes all assertions made by the c.Check() but not assertions made by c.Assert(). This is not very clear in the check.v1 documentation. This doesn't affect this case, but can result in inadvertent passing of a test.
3. It's difficult to mock this behavior if a custom implementation of the check.v1 is used. This also makes it difficult to incrementally migrate away from check.v1.

Pull request type

Please check the type of change your PR introduces:

• 🤖 Test

Issues

• None

Test Plan

No functional change is made. Unit tests will be relied upon for validation.

• ⚡ Unit test

[github-actions]

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

[akankshakumari393]

LGTM