Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
The PR removes some dead code in
pkg/function/scale_test.go
. The reasons for this proposed change are center around the idea that the use ofSucceedNow()
should be avoided. A few reasons for this are:c.Check()
but not assertions made byc.Assert()
. This is not very clear in the check.v1 documentation. This doesn't affect this case, but can result in inadvertent passing of a test.check.v1
is used. This also makes it difficult to incrementally migrate away fromcheck.v1
.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
No functional change is made. Unit tests will be relied upon for validation.