Docs and README update, Profiles and ES charts to pass chart linting, Update google/oauth2 version, Add GCP creds to Profile #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify Elastic Search README * Update kanister version Co-Authored-By: SupriyaKasten <supriya@kasten.io>
* Profiles charts to pass chart linting home and appVersion are required fields * Correct version
Maintainers has to be github aliases addint lint-values.yaml
* Add GCP creds to kanister profile helm * Add location type * Use diff fields to store creds in secret * Address review suggestions * update docs with profile changes
pavannd1
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.