Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor kubeops test to use custom service names #1520

Merged
merged 7 commits into from
Jun 30, 2022
Merged

Refactor kubeops test to use custom service names #1520

merged 7 commits into from
Jun 30, 2022

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented Jun 29, 2022 •
edited by ihcsim

Change Overview

This PR refactors the Kubeops testSuite

Fix #1430.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

go test -v ./pkg/function -check.v -check.f KubeOpsSuite

=== RUN   Test
PASS: kubeops_test.go:194: KubeOpsSuite.TestKubeOps     2.241s
PASS: kubeops_test.go:249: KubeOpsSuite.TestKubeOpsCreateDeleteWithCoreResource 0.119s
PASS: kubeops_test.go:286: KubeOpsSuite.TestKubeOpsCreateWaitDelete     3.332s
OK: 3 passed
--- PASS: Test (5.73s)
PASS
ok      github.com/kanisterio/kanister/pkg/function     5.754s

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jun 29, 2022
pavannd1
pavannd1 reviewed Jun 29, 2022
View reviewed changes
pkg/function/kubeops_test.go Outdated
@@ -205,10 +208,10 @@ func (s *KubeOpsSuite) TestKubeOps(c *C) {
expResource resourceRef
}{
{
bp: newCreateResourceBlueprint(createInSpecsNsPhase(s.namespace)),
bp: newCreateResourceBlueprint(createInSpecsNsPhase(testServiceName, s.namespace)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add random string to this name also

@pavannd1 pavannd1 requested a review from ihcsim June 29, 2022 23:08
ihcsim
ihcsim approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks 👍.

Kanister automation moved this from In Progress to Reviewer approved Jun 30, 2022
@mergify mergify bot merged commit b561303 into master Jun 30, 2022
@mergify mergify bot deleted the kanister_1430 branch June 30, 2022 16:54
Kanister automation moved this from Reviewer approved to Done Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits left review comments

@ihcsim ihcsim ihcsim approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] TestKubeOpsCreateDeleteWithCoreResource test fails intermittently on CI
4 participants
@akankshakumari393 @ihcsim @pavannd1 @viveksinghggits