-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor kubeops test to use custom service names #1520
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
pkg/function/kubeops_test.go
Outdated
@@ -205,10 +208,10 @@ func (s *KubeOpsSuite) TestKubeOps(c *C) { | |||
expResource resourceRef | |||
}{ | |||
{ | |||
bp: newCreateResourceBlueprint(createInSpecsNsPhase(s.namespace)), | |||
bp: newCreateResourceBlueprint(createInSpecsNsPhase(testServiceName, s.namespace)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add random string to this name also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks 👍.
Change Overview
This PR refactors the Kubeops testSuite
Fix #1430.
Pull request type
Please check the type of change your PR introduces:
Issues
TestKubeOpsCreateDeleteWithCoreResource
test fails intermittently on CI #1430Test Plan
go test -v ./pkg/function -check.v -check.f KubeOpsSuite