-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kopia wrappers - B] Add command wrappers in the Kopia package #1526
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
The golint issues are resolved in child PR #1557. Lint check will pass here once that PR is merged. |
Personally, I prefer we review and merge this PR, only when there are actual code calling them, to avoid adding unused code. I have a feeling that some of these code will change, once we start adding the caller code. Or if we are sure that all these code will be used, and they have been reviewed and tested downstream, then why not just merge them now? |
I think you'd have to remove some unused consts to allow this PR to merge. You can add them in the following PR where they are actually used. |
c55d1fa
to
75d1885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Change Overview
This PR creates wrappers to various kopia commands under kopia package
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan