Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volume name as vol-<uuid> #1547

Merged
merged 3 commits into from
Jul 12, 2022
Merged

volume name as vol-<uuid> #1547

merged 3 commits into from
Jul 12, 2022

Conversation

AKhoria
Copy link
Contributor

@AKhoria AKhoria commented Jul 7, 2022 •
edited by pavannd1

Change Overview

Using vol- as volume name of created pods instead of vol-, in order to prevent the name be longer than 63 chars

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 7, 2022
Kanister automation moved this from In Progress to Reviewer approved Jul 11, 2022
ihcsim
ihcsim approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@pavannd1 pavannd1 added the kueue label Jul 12, 2022
@mergify mergify bot merged commit befdee2 into master Jul 12, 2022
Kanister automation moved this from Reviewer approved to Done Jul 12, 2022
@mergify mergify bot deleted the akhoria/pv-short-name branch July 12, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcsim ihcsim ihcsim approved these changes

@pavannd1 pavannd1 pavannd1 approved these changes

@eric-nadeau eric-nadeau Awaiting requested review from eric-nadeau

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Job Pod Failure Due To Invalid Volume Name
3 participants
@AKhoria @ihcsim @pavannd1