Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the example of KubeExecAll kanister function #1551

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Conversation

viveksinghggits
Copy link
Contributor

@viveksinghggits viveksinghggits commented Jul 13, 2022

Change Overview

The example in the KubeExecAll was incorrect. This corrects that.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Create a blueprint with below manifest and run the action

apiVersion: cr.kanister.io/v1alpha1
kind: Blueprint
metadata:
  name: cassandra-blueprint
actions:
  backup:
    phases:
    - func: KubeExecAll
      name: examplePhase
      args:
        namespace: "{{ .Deployment.Namespace }}"
        pods: "{{ index .Deployment.Pods 0 }} {{ index .Deployment.Pods 1 }}"
        containers: "nginx"
        command:
          - sh
          - -c
          - |
            echo "Example"

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 13, 2022
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Jul 13, 2022
docs/functions.rst Outdated Show resolved Hide resolved
docs/functions.rst Show resolved Hide resolved
@mergify mergify bot merged commit f680d73 into master Jul 13, 2022
@mergify mergify bot deleted the kexecall-docs-fix branch July 13, 2022 09:43
Kanister automation moved this from Reviewer approved to Done Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants