-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vsphere: list snapshot by description #1555
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
1c769aa
to
0e36f86
Compare
0e36f86
to
babe899
Compare
Code change LGTM. @carlbraganza @bathina2 PTAL and see if it's mergeable. Thanks. |
b83aae4
to
26b775e
Compare
pkg/blockstorage/vmware/vmware.go
Outdated
return res, err | ||
} | ||
|
||
func (p *FcdProvider) getCreatedSnapshot(ctx context.Context, description string, volID string, notEarlierThan time.Time) interface{} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a return type of interface{}
? You are treating the returned value as a bool
in the calling function so use that type!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are treating its as Types.ID, I've changed the code to returnung Types.ID explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good. I still have a question or two...
* vmware ListSnapshot by description * vmware ListSnapshot by description * vmware check if failed snapshot creation created snapshot * vmware check if failed snapshot creation created snapshot * vmware check if failed snapshot creation created snapshot * vmware moving snapshot description out of loop * fix by review * fix by review * add comments * fix by review * fix by review * fix by review * fix by review Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Change Overview
Add alternative way to list snapshots in Fcd provider by using description field
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan