Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct logic to return true if allOf conditions in wait pass #1565

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Correct logic to return true if allOf conditions in wait pass #1565

merged 1 commit into from
Jul 24, 2022

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Jul 22, 2022 •
edited

Change Overview

This PR fixes an issue where allOf clause in the Wait function conditions was always returning false regardless of individual condition result.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Jul 22, 2022
@PrasadG193
Correct logic to return true if allOf conditions in wait pass
a7e8598 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
ihcsim
ihcsim approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 👍

Kanister automation moved this from In Progress to Reviewer approved Jul 22, 2022
@mergify mergify bot merged commit 5e26f7a into master Jul 24, 2022
Kanister automation moved this from Reviewer approved to Done Jul 24, 2022
@mergify mergify bot deleted the fix-wait-allof-clause branch July 24, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcsim ihcsim ihcsim approved these changes

@viveksinghggits viveksinghggits Awaiting requested review from viveksinghggits

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] allOf clause on Wait condition always return false
2 participants
@PrasadG193 @ihcsim