-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference architecture for using Kanister with Argo Workflows #1566
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will break down my reviews into parts to speed things up
In most of the scenarios when we ask users to create an actionset using kanctl, we (kanctl) query a lot of things (k8s resources) that are passed to the kanctl command line tool. |
@viveksinghggits The main goal of this document is to provide a reference to scheduling actions using Argo Workflows for interested users. Consider it as a tutorial similar to the blueprint examples and the Grafana/Loki example we have in the documentation. As with those documents (we make assumptions in there too), we are only showcasing how we integrate with ArgoWorkflows and not providing a standard way to schedule actions in Kanister. Given the purpose of this tutorial, I think it's acceptable to use the |
I experimented with a lower A note can be added saying that using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I think it's well structured 👍🏼 💯
Minor improvements suggested. Should be good to merge once accepted.
One thing to follow up on in a separate PR would be to add commands to verify creations and deletions wherever they are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job @aish-where-ya 🥇
@viveksinghggits Please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…nisterio#1566) * Add reference architecture for using Kanister with Argo Workflows * Minor fix to underline * Changed font in the architecture image. * Addressed Vivek's review * Addressed changes suggested by Vivek and Akanksha. * Addressed Vivek's comments regarding RBAC * Addressed Pavan's review comments. * Addressed Pavan's additional review comments * [nit] Update Step 2 heading Co-authored-by: Pavan Navarathna <6504783+pavannd1@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Change Overview
This PR adds a reference architecture for using Kanister with Argo Workflows to automate creation of backup ActionSets.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan