Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update couchbase tooling image #1593

Merged
merged 7 commits into from
Aug 16, 2022
Merged

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Aug 12, 2022

Change Overview

  • Update couchbase tooling image in the couchbase blueprint.
  • Update the pkg/app/couchbase.go for integration testing with respect to the latest couchbase release

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • Update the values of SHORT_APPS variable from build/integration-test.sh from SHORT_APPS="^PostgreSQL$|^MySQL$|Elasticsearch|^MongoDB$|Maria|^MSSQL$" to SHORT_APPS="^Couchbase$"

  • Install Minio
    $ bash build/minio.sh install_minio

  • Run following command
    $ bash build/integration-test.sh short

Output:

Running integration tests:
~/go/src/github.com/kanisterio/kanister/pkg/testing ~/go/src/github.com/kanisterio/kanister
=== RUN   Test
{"File":"pkg/testing/integration_test.go","Function":"github.com/kanisterio/kanister/pkg/testing.(*IntegrationSuite).TestRun","Line":196,"app":"couchbase","level":"info","msg":"Running e2e integration test.","testName":"Couchbase.TestRun","time":"2022-08-12T13:51:11.422161807+05:30"}
{"File":"pkg/app/couchbase.go","Function":"github.com/kanisterio/kanister/pkg/app.(*CouchbaseDB).Install","Line":82,"app":"couchbase","level":"info","msg":"Installing couchbase operator and cluster helm chart.","time":"2022-08-12T13:51:11.450950415+05:30"}
.
.
.
{"ActionSet":"delete-test-actionset-mckwx-zzr4z","File":"pkg/controller/controller.go","Function":"github.com/kanisterio/kanister/pkg/controller.(*Controller).logAndSuccessEvent","Line":652,"level":"info","msg":"Updated ActionSet 'delete-test-actionset-mckwx-zzr4z' Status-\u003ecomplete","time":"2022-08-12T13:56:07.041087691+05:30"}
{"File":"pkg/app/couchbase.go","Function":"github.com/kanisterio/kanister/pkg/app.CouchbaseDB.Uninstall","Line":245,"app":"couchbase","level":"info","msg":"Uninstalling helm charts.","namespace":"couchbase-test","release":"couchbase-h8wqm","time":"2022-08-12T13:56:15.834441762+05:30"}
OK: 1 passed
--- PASS: Test (306.65s)
PASS

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

r4rajat and others added 2 commits August 12, 2022 18:37
Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>
- Update IsReady and Ping Methods with respect to the current release of couchbase.

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 12, 2022
pkg/app/couchbase.go Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Aug 12, 2022
r4rajat and others added 3 commits August 13, 2022 11:54
- Update IsReady and Ping Methods with respect to the current release of couchbase.

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>
- Update IsReady and Ping Methods with respect to the current release of couchbase.

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>
pkg/app/couchbase.go Outdated Show resolved Hide resolved
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@pavannd1 pavannd1 added the kueue label Aug 16, 2022
@mergify mergify bot merged commit 58a2bf4 into master Aug 16, 2022
Kanister automation moved this from Reviewer approved to Done Aug 16, 2022
@mergify mergify bot deleted the update-couchbase-tooling-image branch August 16, 2022 18:02
r4rajat added a commit to r4rajat/kanister that referenced this pull request Aug 28, 2022
* Update couchbase tooling image

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>

* Update IsReady and Ping Methods

- Update IsReady and Ping Methods with respect to the current release of couchbase.

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>

* Update IsReady and Ping Methods

- Update IsReady and Ping Methods with respect to the current release of couchbase.

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>

* Update IsReady and Ping Methods

- Update IsReady and Ping Methods with respect to the current release of couchbase.

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>

* Fix linting

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>

Signed-off-by: Rajat Gupta <Rajat.11605708@lpu.in>
Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Tooling images in Couchbase example BPs are outdated
4 participants