Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos #1617

Merged
Merged

Conversation

leuyentran
Copy link
Contributor

@leuyentran leuyentran commented Sep 1, 2022

Signed-off-by: Le Tran le.tran@kasten.io

Change Overview

Draft waiting for #1615 to refactor additional content here

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

Signed-off-by: Le Tran <le.tran@kasten.io>
@leuyentran leuyentran force-pushed the Refactor-fix-typo-on-AzureClientId-and-AzureClientSecret branch from d2b5c7e to 66cfc98 Compare September 2, 2022 15:10
@PrasadG193
Copy link
Contributor

ok-to-test

Kanister automation moved this from In Progress to Reviewer approved Sep 7, 2022
Copy link
Contributor

@onkarbhat onkarbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for following up about the typos.

@leuyentran leuyentran marked this pull request as ready for review September 8, 2022 16:41
…reClientSecret

Signed-off-by: Le Tran <le.tran@kasten.io>
@leuyentran leuyentran force-pushed the Refactor-fix-typo-on-AzureClientId-and-AzureClientSecret branch from 226ce26 to fc204f1 Compare September 8, 2022 21:30
@mergify mergify bot merged commit c106938 into master Sep 9, 2022
Kanister automation moved this from Reviewer approved to Done Sep 9, 2022
@mergify mergify bot deleted the Refactor-fix-typo-on-AzureClientId-and-AzureClientSecret branch September 9, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants