-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Image Tag to v9.99.9-dev only for ghcr/kanisterio images #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f it has ghcr/kanisterio prefix Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
…f it has ghcr/kanisterio prefix Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
5426f8e
to
57afc6c
Compare
…o update_tag_logic
…io/kanisterio` have tags updated Minor Refactor
ok-to-test |
1 similar comment
ok-to-test |
viveksinghggits
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akanksha Kumari akankshakumari393@gmail.com
Change Overview
We generally use
v9.99.9-dev
images for Integration test. And for that when we register an app we set the third argument of NewBlueprint function to true, It overwrites all the images in the blueprint to usev9.99.9-dev
tag. Now logic would also update the tag of the images in the blueprint that are not fromghcr.io/kanisterio
repo, which might later fail because ofErrPullImage
This PR make sure that we are only updating of the tag of images which are from "ghcr.io/kanisterio" repo.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Tested the changes cockroachDB blueprint, where we are using "cockroachdb/cockroach" image in the blueprint.
The tag of this image was not updated.