Add new flag to override actionset name #1625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR adds a new flag called
--actionset-name
to thekanctl create actionset
command. The current mechanism to auto-generate the new actionset name based on the provided action name (with--action
) and parent actionset name (with--from
) is unreliable. The resource creation will fail if the auto-generated name doesn't comply with the K8s resource naming constraints. See #1414.The new flag allows user to override the auto-generation mechanism to use one provided by the user.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Deploy this blueprint where the action's name is in the camel case format:
Deploy this actionset to execute the
echoTask
action:Use
kanctl
to create an actionset, using the previous actionset as its parent:Expect the above command to fail:
Re-run the command again with the
-A
/--actionset-name
flag:Expect the actionset to be created successfully: