Update Profile Bucket Validation Code To Account For Custom S3 Endpoint #1631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR updates the
validate.ProfileBucket()
method to use custom S3 endpoint, if provided, for its validation steps. Without this change,stow
will default back to using thes3.<region>.amazonaws.com
domain, even though the custom endpoint is provided.Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Use the latest
kanctl
CLI to reproduce the issue:The validation code ignores the
s3.cern.ch
endpoint:Run
kanctl
with this change:The right endpoint is used: