Update Profile Bucket Validation Code To Account For Custom S3 Endpoint

[ihcsim]

Change Overview

This PR updates the validate.ProfileBucket() method to use custom S3 endpoint, if provided, for its validation steps. Without this change, stow will default back to using the s3.<region>.amazonaws.com domain, even though the custom endpoint is provided.

Pull request type

Please check the type of change your PR introduces:

• 🚧 Work in Progress
• 🌈 Refactoring (no functional changes, no api changes)
• 🐹 Trivial/Minor
• 🐛 Bugfix
• 🌻 Feature
• 🗺️ Documentation
• 🤖 Test

Issues

• fixes [BUG] Wrong URL for S3 endpoint  #1590

Test Plan

Use the latest kanctl CLI to reproduce the issue:

$ kanctl create profile s3compliant --access-key "test" --secret-key "test" --endpoint https://s3.cern.ch/  --bucket my-bucket --region cern --namespace default --verbose

The validation code ignores the s3.cern.ch endpoint:

secret 's3-secret-ggiorh' created
Failed the 'Validate bucket region specified in profile' check.. ❌
validation failed, deleting secret 's3-secret-ggiorh'
secret 's3-secret-ggiorh' deleted
Error: profile validation failed: failed to get bucket my-bucket: GetBucketLocation: RequestError: send request failed
caused by: Get "https://s3.cern.amazonaws.com/my-bucket?location=": dial tcp: lookup s3.cern.amazonaws.com on 127.0.0.53:53: no such host

Run kanctl with this change:

go run ./cmd/kanctl create profile s3compliant --access-key "test" --secret-key "test" --endpoint https://s3.cern.ch/  --bucket my-buclet --region cern --namespace default --verbose

The right endpoint is used:

secret 's3-secret-ijj2lv' created
Failed to obtain reader, failed to marshal fields to JSON, json: unsupported type: func(time.Duration)
Failed the 'Validate bucket region specified in profile' check.. ❌
validation failed, deleting secret 's3-secret-ijj2lv'
secret 's3-secret-ijj2lv' deleted
Error: profile validation failed: failed to get bucket my-bucket: GetBucketLocation: InvalidAccessKeyId: 
        status code: 403, request id: tx000000000000049299681-00631bb733-2af9b497-default, host id: 
{"File":"pkg/kanctl/kanctl.go","Function":"github.com/kanisterio/kanister/pkg/kanctl.Execute","Line":48,"error":"profile validation failed: failed to get bucket my-bucket: GetBucketLocation: InvalidAccessKeyId: \n\tstatus code: 403, request id: tx000000000000049299681-00631bb733-2af9b497-default, host id: ","level":"info","msg":"Kanctl failed to execute","time":"2022-09-09T14:59:15.597305194-07:00"}
exit status 1

• 💪 Manual
• ⚡ Unit test
• 💚 E2E

[github-actions]

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

[PrasadG193]

LGTM

[ihcsim]

/ok-to-test

[ihcsim]

/ok-to-test

[ihcsim]

/ok-to-test

[akankshakumari393]

/ok-to-test

[ihcsim]

/ok-to-test