Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CockroachDB in integration tests #1632

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Add CockroachDB in integration tests #1632

merged 1 commit into from
Sep 12, 2022

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Sep 12, 2022

Signed-off-by: Rajat Gupta rajat.gupta@veeam.com

Change Overview

Add CockroachDB in Integration Tests.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

$ make integration-test
running CMD in the containerized build environment
Running integration tests:
/go/src/github.com/kanisterio/kanister/pkg/testing /go/src/github.com/kanisterio/kanister
go: downloading github.com/kastenhq/check v0.0.0-20180626002341-0264cfcea734
..
..
..
OK: 7 passed
--- PASS: Test (466.96s)
PASS
ok  	github.com/kanisterio/kanister/pkg/testing	467.010s
/go/src/github.com/kanisterio/kanister
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Signed-off-by: Rajat Gupta <rajat.gupta@veeam.com>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Sep 12, 2022
Kanister automation moved this from In Progress to Reviewer approved Sep 12, 2022
@r4rajat r4rajat added the kueue label Sep 12, 2022
@mergify mergify bot merged commit 5786c9d into master Sep 12, 2022
@mergify mergify bot deleted the add-cockroachdb-test branch September 12, 2022 10:36
Kanister automation moved this from Reviewer approved to Done Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants