Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure MysqlDB app via Options #1633

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Conversation

alexvbg
Copy link
Contributor

@alexvbg alexvbg commented Sep 12, 2022

Change Overview

This PR add ability to configure MysqlDB app via options + added function that help us configure chart values for that app.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Sep 12, 2022
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you please briefly explain why are we trying to add ipv6 support in MySQL?

pkg/app/mysql.go Outdated Show resolved Hide resolved
@alexvbg alexvbg changed the title Add new constructor for MysqlDB for ipv6 network Add ability to configure MysqlDB app via Options Sep 12, 2022
pkg/app/mysql.go Outdated Show resolved Hide resolved
@alexvbg alexvbg removed the kueue label Sep 13, 2022
Kanister automation moved this from In Progress to Reviewer approved Sep 13, 2022
@alexvbg alexvbg added the kueue label Sep 13, 2022
@mergify mergify bot merged commit 9f8d11a into master Sep 13, 2022
Kanister automation moved this from Reviewer approved to Done Sep 13, 2022
@mergify mergify bot deleted the ipv6-mysql-app branch September 13, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants