Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RepositoryServer controller #1653

Merged
merged 233 commits into from
Apr 5, 2023
Merged

Conversation

shlokc9
Copy link
Contributor

@shlokc9 shlokc9 commented Sep 30, 2022

Change Overview

This PR adds a RepositoryServer controller in Kanister

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

…/customresource, pkg/apis and pkg/client respectively
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Sep 30, 2022
alexvbg and others added 10 commits September 30, 2022 13:23
* Add ability to configure MongoDB app via Options

* after review
added interface HelmApp and implemented in MongoDB and MysqlDB structs

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Expose Azure authenticators

* Fix typo

* Add support for default msi id by allowing for Azure client ID to exist but be empty

* Clean up based on PR suggestions

Co-authored-by: Le Tran <le.tran@kasten.io>
Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
Bumps [github.com/vmware/govmomi](https://github.com/vmware/govmomi) from 0.28.0 to 0.29.0.
- [Release notes](https://github.com/vmware/govmomi/releases)
- [Changelog](https://github.com/vmware/govmomi/blob/master/CHANGELOG.md)
- [Commits](vmware/govmomi@v0.28.0...v0.29.0)

---
updated-dependencies:
- dependency-name: github.com/vmware/govmomi
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
cmd/reposervercontroller/main.go Outdated Show resolved Hide resolved
cmd/reposervercontroller/main.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/handler.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/handler.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/handler.go Outdated Show resolved Hide resolved
}

func (h *RepoServerHandler) createOrUpdateClientUsers() error {
repoPassword := string(h.RepositoryServerSecrets.repositoryPassword.Data[repoPasswordKey])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the resolution here?

pkg/controllers/repositoryserver/server.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/server.go Show resolved Hide resolved
pkg/controllers/repositoryserver/server.go Outdated Show resolved Hide resolved
pkg/controllers/repositoryserver/server.go Outdated Show resolved Hide resolved
@kale-amruta kale-amruta force-pushed the kopia-repository-server-controller branch from 649e32b to e4608b2 Compare February 28, 2023 09:16
Base automatically changed from kopia-repository-server-crd to master March 1, 2023 07:10
@kale-amruta kale-amruta force-pushed the kopia-repository-server-controller branch from 0a5ea35 to 43ef5dd Compare March 29, 2023 07:30
pkg/consts/consts.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

pkg/consts/consts.go Outdated Show resolved Hide resolved
Kanister automation moved this from In Progress to Reviewer approved Apr 3, 2023
@kale-amruta kale-amruta force-pushed the kopia-repository-server-controller branch from 64bb10c to 4761fe3 Compare April 5, 2023 09:56
@mergify mergify bot merged commit 52d0830 into master Apr 5, 2023
Kanister automation moved this from Reviewer approved to Done Apr 5, 2023
@mergify mergify bot deleted the kopia-repository-server-controller branch April 5, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

8 participants