Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CONTRIBUTING.md with slack url #1656

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Updating CONTRIBUTING.md with slack url #1656

merged 3 commits into from
Oct 4, 2022

Conversation

Sagar2366
Copy link
Contributor

@Sagar2366 Sagar2366 commented Oct 1, 2022 •
edited by PrasadG193

Change Overview

Updating Slack URL in CONTRIBUTING.md

Pull request type

Please check the type of change your PR introduces:

  • 🗺️ Documentation

Issues

@Sagar2366
Updating CONTRIBUTING.md with slack url
3781c49 
Updating CONTRIBUTING.md with slack url
PrasadG193
PrasadG193 approved these changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @Sagar2366

@PrasadG193
Copy link
Contributor

PrasadG193 commented Oct 1, 2022 •
edited

@ihcsim @pavannd1 not related, but should we have Slack invite link here instead of the Workspace login link?

@Sagar2366 Sagar2366 mentioned this pull request Oct 1, 2022
Closed
ihcsim
ihcsim reviewed Oct 3, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
ihcsim
ihcsim reviewed Oct 3, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Sagar2366
Copy link
Contributor Author

/recheck

@ihcsim ihcsim added the kueue label Oct 4, 2022
@mergify mergify bot merged commit 3d8e59a into kanisterio:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcsim ihcsim ihcsim left review comments

@pavannd1 pavannd1 pavannd1 left review comments

@PrasadG193 PrasadG193 PrasadG193 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while connecting to kanister.io slack
4 participants
@Sagar2366 @PrasadG193 @ihcsim @pavannd1