Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to cloned snapshots #1662

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Conversation

AKhoria
Copy link
Contributor

@AKhoria AKhoria commented Oct 5, 2022

Change Overview

This PR adds new parameter labels to Snapshotter.Clone and Snapshotter.CreateFromSource which allows us to clone snapshot with custom labels

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 5, 2022
Copy link
Contributor

@bathina2 bathina2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Oct 7, 2022
@AKhoria AKhoria added the kueue label Oct 20, 2022
@mergify mergify bot merged commit 4dca8c8 into master Oct 21, 2022
Kanister automation moved this from Reviewer approved to Done Oct 21, 2022
@mergify mergify bot deleted the ankhoria/add-labels-to-snapshot-clone branch October 21, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants