Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tags in SnapshotCreate Kopia Wrapper #1664

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Add Tags in SnapshotCreate Kopia Wrapper #1664

merged 1 commit into from
Oct 11, 2022

Conversation

r4rajat
Copy link
Contributor

@r4rajat r4rajat commented Oct 7, 2022 •
edited

Change Overview

Add Tags as an Argument in the SnapshotCreate Kopia Wrapper

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 7, 2022
@r4rajat r4rajat requested a review from pavannd1 October 7, 2022 14:10
@r4rajat r4rajat changed the title Add Tags in CreateSnapshot Kopia Wrapper Add Tags in SnapshotCreate Kopia Wrapper Oct 7, 2022
@r4rajat r4rajat requested a review from shlokc9 October 10, 2022 09:07
ankitjain235
ankitjain235 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@ankitjain235 ankitjain235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Oct 11, 2022
shlokc9
shlokc9 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@shlokc9 shlokc9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍🏼

@r4rajat r4rajat self-assigned this Oct 11, 2022
@r4rajat r4rajat added the kueue label Oct 11, 2022
@mergify mergify bot merged commit e1bfd96 into master Oct 11, 2022
Kanister automation moved this from Reviewer approved to Done Oct 11, 2022
@mergify mergify bot deleted the Add-Tags-In-CreateSnapshot-Wrapper branch October 11, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitjain235 ankitjain235 ankitjain235 approved these changes

@shlokc9 shlokc9 shlokc9 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees

@r4rajat r4rajat

Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r4rajat @ankitjain235 @shlokc9