Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up PR for #1650 #1668

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Follow-up PR for #1650 #1668

merged 1 commit into from
Oct 11, 2022

Conversation

ed-shilo
Copy link
Contributor

@ed-shilo ed-shilo commented Oct 10, 2022

Change Overview

Addressing additional comments from #1650

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 10, 2022
@ed-shilo ed-shilo mentioned this pull request Oct 10, 2022
10 tasks
Copy link
Contributor

@ihcsim ihcsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.

@viveksinghggits PTAL.

Kanister automation moved this from In Progress to Reviewer approved Oct 11, 2022
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ed-shilo ed-shilo added the kueue label Oct 11, 2022
@mergify mergify bot merged commit 1b6ab8f into master Oct 11, 2022
Kanister automation moved this from Reviewer approved to Done Oct 11, 2022
@mergify mergify bot deleted the keu/ed-shilo/as-perf branch October 11, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants