-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build other kanister tools with goboring #1670
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
Merge branch 'boring_kopia_2' of https://github.com/kanisterio/kanister into boring_kando
docker/build/Dockerfile
Outdated
|
||
LABEL maintainer="Tom Manville<tom@kasten.io>" | ||
|
||
RUN apk add --update --no-cache ca-certificates bash git docker curl jq \ | ||
&& update-ca-certificates \ | ||
&& rm -rf /var/cache/apk/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intended => omitting rm -rf /var/cache/apk/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I thought I cleaned that up, will fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julio-lopez wait I did clean it up. Yes it was intended. Will there be an apk cache if we are using apt-get
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. Not an apk cache, but a deb cache. So this needs to be updated for that, not removed altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment, otherwise LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1: LG 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems safe to merge. Let's merge it, and have it go through the pipeline to surface potential issues.
Change Overview
Build kando with GO boring enabled.
This involves updating the build image to use
golang:1.19.2-buster
which updates the go version and also uses glibc instead of musl (alpine).Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan