Build other kanister tools with goboring #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
Merge branch 'boring_kopia_2' of https://github.com/kanisterio/kanister into boring_kando
julio-lopez
reviewed
Oct 13, 2022
docker/build/Dockerfile
Outdated
|
|
||
| LABEL maintainer="Tom Manville<tom@kasten.io>" | ||
|
|
||
| RUN apk add --update --no-cache ca-certificates bash git docker curl jq \ | ||
| && update-ca-certificates \ | ||
| && rm -rf /var/cache/apk/* |
There was a problem hiding this comment.
Is this change intended => omitting rm -rf /var/cache/apk/*
There was a problem hiding this comment.
Ah I thought I cleaned that up, will fix it
There was a problem hiding this comment.
@julio-lopez wait I did clean it up. Yes it was intended. Will there be an apk cache if we are using apt-get?
There was a problem hiding this comment.
Oh, I see. Not an apk cache, but a deb cache. So this needs to be updated for that, not removed altogether.
julio-lopez
reviewed
Oct 13, 2022
julio-lopez
reviewed
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Build kando with GO boring enabled.
This involves updating the build image to use
golang:1.19.2-busterwhich updates the go version and also uses glibc instead of musl (alpine).Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan