Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 'triage' workflow on PRs from original repo only #1672

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

ihcsim
Copy link
Contributor

@ihcsim ihcsim commented Oct 11, 2022

Change Overview

This PR updates GitHub Actions to run the triage workflow only on PRs originated from the main (non-fork) repo. This ensures that external PRs are reviewed prior to being added to the project board. It's also safer than using the pull_request_target event hook as discussed in #1671 (comment).

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Signed-off-by: Ivan Sim <ivan.sim@kasten.io>
@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 11, 2022
@ihcsim ihcsim changed the title Run 'triage' workflow on original repo only Run 'triage' workflow on PRs from original repo only Oct 11, 2022
Kanister automation moved this from In Progress to Reviewer approved Oct 12, 2022
@ihcsim ihcsim merged commit 655c5c3 into master Oct 12, 2022
Kanister automation moved this from Reviewer approved to Done Oct 12, 2022
@ihcsim ihcsim deleted the triage-workflow branch October 12, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants