Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kopia dockerfile for goboring #1673

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Update kopia dockerfile for goboring #1673

merged 9 commits into from
Oct 20, 2022

Conversation

bathina2
Copy link
Contributor

@bathina2 bathina2 commented Oct 11, 2022

Change Overview

This PR builds the kopia image using GO_BORING flags instead of using upstream goreleaser.
It also changes the the base image to buster since alpine uses the musl-libc library which is not present in the UBI-minimal image.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Oct 11, 2022
Makefile Show resolved Hide resolved
build/update_kopia_image.sh Outdated Show resolved Hide resolved
docker/kopia-build/Dockerfile Outdated Show resolved Hide resolved
docker/kopia-build/Dockerfile Show resolved Hide resolved
@bathina2 bathina2 added the kueue label Oct 19, 2022
Copy link
Contributor

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
🚢it :shipit: 🚀

Kanister automation moved this from In Progress to Reviewer approved Oct 19, 2022
@viveksinghggits viveksinghggits merged commit 94affa6 into master Oct 20, 2022
@viveksinghggits viveksinghggits deleted the boring_kopia_2 branch October 20, 2022 17:26
Kanister automation moved this from Reviewer approved to Done Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants